(#16070) Allow optional order parameter to apt::pin #83
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dalen The functionality that this introduces is pretty reasonable, but I have concerns about how this would effect current apt module users that upgrade the module (it would create new files when nothing actually changed) Is it reasonable to write this in a way that would not effect current users? (IE, only add the file prefix and '-' if an order was specified.) |
|
Sure, that seems reasonable. I was thinking about the use case with purge_preferences_d set to true, then it doesn't really matter. But if that is false we would want to avoid creating duplicate files, yes. |
As the apt pinnings are parsed in ascending alphabetical order with first match wins within a given scope it is useful to be able to specify a ordering parameter. Then the name parameter can be kept to something meaningful.
branan
pushed a commit
that referenced
this pull request
Oct 18, 2012
(#16070) Allow optional order parameter to apt::pin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the apt pinnings are parsed in ascending alphabetical order with
first match wins within a given scope it is useful to be able to specify
a ordering parameter. Then the name parameter can be kept to something
meaningful.